-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the untranslated text content of Dashboard page #13024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13024 +/- ##
===========================================
+ Coverage 53.38% 72.97% +19.58%
===========================================
Files 489 546 +57
Lines 17315 20175 +2860
Branches 4482 5268 +786
===========================================
+ Hits 9244 14723 +5479
+ Misses 8071 5327 -2744
- Partials 0 125 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! It seems you need to fix a linting error - apart from that LGTM
@villebro |
* master: fix: UI toast typo (apache#13026) feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602) fix(build): black failing on master, add to required checks (apache#13039) fix: time filter db migration optimization (apache#13015) fix: untranslated text content of Dashboard page (apache#13024) fix(ci): remove signature requirements for commits to master (apache#13034) fix: add alerts and report to default config (apache#12999) docs(changelog): add entries for 1.0.1 (apache#12981) ci: skip cypress if no code changes (apache#12982) chore: add cypress required checks for branch protection (apache#12970) Refresh dashboard list after bulk delete (apache#12945) Updates storybook to version 6.1.17 (apache#13014) feat: Save datapanel state in local storage (apache#12996) fix: added text and changed margins (apache#12923) chore: Swap Slack Url 2 more places (apache#13004)
* fix: fix the untranslated text content of Dashboard page * fix: add the untranslated text content of Dashboard page in messages.pot * fix linting error Co-authored-by: chenx <yuxiang1989>
SUMMARY
fix the untranslated text content of Dashboard page. At present, some fields are not translated
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
ADDITIONAL INFORMATION